feat: drop support for php < 8.1 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drop support for symfony < 5.4 add "ext-simplexml" as required add strong types
composer.json
Outdated
| @@ -13,8 +13,9 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=5.5", | |||
| "symfony/yaml": "^3.2 | ^4.0 | ^5.0 | ^6.0" | |||
| "php": ">=8.1", | |||
There was a problem hiding this comment.
You mean ~8.1.0 || ~8.2.0 || ~8.3.0 ?
src/Country.php
Outdated
| * @param int $minorUnit | ||
| */ | ||
| public function __construct($entity, $currency, $alphabeticCode, $numericCode, $minorUnit) | ||
| public function __construct(private readonly string $entity, |
src/Country.php
Outdated
| private readonly string $currency, | ||
| private readonly string $alphabeticCode, | ||
| private readonly int $numericCode, | ||
| private readonly int $minorUnit) |
There was a problem hiding this comment.
i changed identation betwen type and variable name. I am not sure if you that is what you mean.
I am not sure where exact you want me to add the new line
Closed
|
Let's get this is in, with the minor changes I suggested. |
drop support for symfony < 5.4 add "ext-simplexml" as required add strong types
|
The two new lines and indentation are still left. If you correct them I will press the button. |
drop support for symfony < 5.4 add "ext-simplexml" as required add strong types
|
I am not sure how exactly you want it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop support for symfony < 5.4
add "ext-simplexml" as required
add strong types
As i was working in #14
i made some more changes for a new major version. There are BC breaks, and i am not sure about the changes in the interface.