-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop support for php < 8.1 #15
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,85 +1,37 @@ | ||
<?php | ||
namespace MoneyPHP\IsoCurrencies; | ||
|
||
/** | ||
* Class Country | ||
* @package MoneyPHP\IsoCurrencies | ||
*/ | ||
final class Country | ||
{ | ||
/** | ||
* @var string | ||
*/ | ||
private $alphabeticCode; | ||
/** | ||
* @var string | ||
*/ | ||
private $currency; | ||
/** | ||
* @var string | ||
*/ | ||
private $entity; | ||
/** | ||
* @var int | ||
*/ | ||
private $minorUnit; | ||
/** | ||
* @var int | ||
*/ | ||
private $numericCode; | ||
|
||
/** | ||
* @param string $entity | ||
* @param string $currency | ||
* @param string $alphabeticCode | ||
* @param int $numericCode | ||
* @param int $minorUnit | ||
*/ | ||
public function __construct($entity, $currency, $alphabeticCode, $numericCode, $minorUnit) | ||
public function __construct(private readonly string $entity, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add new line |
||
private readonly string $currency, | ||
private readonly string $alphabeticCode, | ||
private readonly int $numericCode, | ||
private readonly int $minorUnit) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add new line, identation There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i changed identation betwen type and variable name. I am not sure if you that is what you mean. I am not sure where exact you want me to add the new line |
||
{ | ||
$this->alphabeticCode = $alphabeticCode; | ||
$this->currency = $currency; | ||
$this->entity = $entity; | ||
$this->minorUnit = $minorUnit; | ||
$this->numericCode = $numericCode; | ||
} | ||
|
||
/** | ||
* @return string | ||
*/ | ||
public function getAlphabeticCode() | ||
public function getAlphabeticCode(): string | ||
{ | ||
return $this->alphabeticCode; | ||
} | ||
|
||
/** | ||
* @return string | ||
*/ | ||
public function getCurrency() | ||
public function getCurrency(): string | ||
{ | ||
return $this->currency; | ||
} | ||
|
||
/** | ||
* @return string | ||
*/ | ||
public function getEntity() | ||
public function getEntity(): string | ||
{ | ||
return $this->entity; | ||
} | ||
|
||
/** | ||
* @return int | ||
*/ | ||
public function getMinorUnit() | ||
public function getMinorUnit(): int | ||
{ | ||
return $this->minorUnit; | ||
} | ||
|
||
/** | ||
* @return int | ||
*/ | ||
public function getNumericCode() | ||
public function getNumericCode(): int | ||
{ | ||
return $this->numericCode; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~8.1.0 || ~8.2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean ~8.1.0 || ~8.2.0 || ~8.3.0 ?