Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore MOODLE_INTERNAL sniff for all Behat classes. #157

Closed
paulholden opened this issue Nov 8, 2021 · 0 comments · Fixed by #158
Closed

Ignore MOODLE_INTERNAL sniff for all Behat classes. #157

paulholden opened this issue Nov 8, 2021 · 0 comments · Fixed by #158

Comments

@paulholden
Copy link
Member

Mentioned by @stronk7 - we should check whether the file contains a /behat/ folder in it's path, rather than it's immediate descendant having that name:

moodle-local_codechecker/moodle/Sniffs/Files/MoodleInternalSniff.php

Lines 50 to 53 in 5f4cf15

// Special dispensation for behat files.
if (basename(dirname($file->getFilename())) === 'behat') {
return;
}

See MDL-72696 (fails for file lib/behat/form_field/behat_form_inplaceeditable_select.php)
stronk7 added a commit to stronk7/moodle-local_codechecker that referenced this issue Nov 8, 2021
@stronk7
Apply more accurate dispensations for the Moodle internal checks
a53fc9e 
Previously it was simply skipping any file straight under a
"behat" directory. So, at very least these 2 cases were being
handled incorrectly:

1. Subdirectories under "behat" were not skipped.
2. admin/behat directory was being incorrectly skipped.

Now, being able to calculate moodle root, we are going to skip:
1. Any file within dirroot having "/tests/behat" in the path.
2. Any file within dirroot having "/lib/behat" in the path.
3. Any file within dirroot having "/lang/" in the path.

With thatm the 2 original problems should be fixed. Covered.

Fixes moodlehq#157.
stronk7 added a commit to stronk7/moodle-local_codechecker that referenced this issue Nov 8, 2021
@stronk7
Apply more accurate dispensations for the Moodle internal checks
0991f8b 
Previously it was simply skipping any file straight under a
"behat" directory. So, at very least these 2 cases were being
handled incorrectly:

1. Subdirectories under "behat" were not skipped.
2. admin/behat directory was being incorrectly skipped.

Now, being able to calculate moodle root, we are going to skip:
1. Any file within dirroot having "/tests/behat/" in the path.
2. Any file within dirroot having "/lib/behat/" in the path.
3. Any file within dirroot having "/lang/" in the path.

With that the 2 original problems should be fixed.

Covered with unit tests.

Fixes moodlehq#157.
@stronk7 stronk7 mentioned this issue Nov 8, 2021
Merged
stronk7 added a commit that referenced this issue Nov 9, 2021
@stronk7
Apply more accurate dispensations for the Moodle internal checks
db1cd44 
Previously it was simply skipping any file straight under a
"behat" directory. So, at very least these 2 cases were being
handled incorrectly:

1. Subdirectories under "behat" were not skipped.
2. admin/behat directory was being incorrectly skipped.

Now, being able to calculate moodle root, we are going to skip:
1. Any file within dirroot having "/tests/behat/" in the path.
2. Any file within dirroot having "/lib/behat/" in the path.
3. Any file within dirroot having "/lang/" in the path.

With that the 2 original problems should be fixed.

Covered with unit tests.

Fixes #157.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply more accurate dispensations for the Moodle internal checks stronk7/moodle-local_codechecker
1 participant
@paulholden