Apply more accurate dispensations for the Moodle internal checks #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was simply skipping any file straight under a "behat" directory. So, at very least these 2 cases were being handled incorrectly: 1. Subdirectories under "behat" were not skipped. 2. admin/behat directory was being incorrectly skipped. Now, being able to calculate moodle root, we are going to skip: 1. Any file within dirroot having "/tests/behat/" in the path. 2. Any file within dirroot having "/lib/behat/" in the path. 3. Any file within dirroot having "/lang/" in the path. With that the 2 original problems should be fixed. Covered with unit tests. Fixes moodlehq#157.
|
Self-merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was simply skipping any file straight under a
"behat" directory. So, at very least these 2 cases were being
handled incorrectly:
Now, being able to calculate moodle root, we are going to skip:
With that the 2 original problems should be fixed.
Covered with unit tests.
Fixes #157.