Apply all the standard ignores to the "other" checks #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stronk7
force-pushed
the
apply_ignores_to_other_checks
branch
6 times, most recently
from
00d66d0
to
401920b
Compare
When invoking phpcs we pass to it a calculated list of paths to ignore (substring matching). That includes all the third part libraries, some directories like the amd/yui build ones, and the list of exclusions added in the UI. It works ok, so far. But, later, when invoking the "other" checks (an ancient list of custom checks applied to other files, surely to be removed some day), we don't apply all those ignores commented above. This PR just makes those calculated ignores to be also applied to the "other checks". Covered with tests, it seems to be working ok. Also, fixes a problem with MoodleUtil unit tests breaking CFG for next tests. Fixes moodlehq#179.
stronk7
force-pushed
the
apply_ignores_to_other_checks
branch
from
401920b
to
942fdb1
Compare
We need to move to xdebug/pcov alternatives, see: moodlehq/moodle-plugin-ci#94
andrewnicols
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking phpcs we pass to it a calculated list of
paths to ignore (substring matching).
That includes all the third part libraries, some directories
like the amd/yui build ones, and the list of exclusions added
in the UI.
It works ok, so far.
But, later, when invoking the "other" checks (an ancient list
of custom checks applied to other files, surely to be removed
some day), we don't apply all those ignores commented above.
This PR just makes those calculated ignores to be also applied to
the "other checks". Covered with tests, it seems to be working ok.
Also, fixes a problem with MoodleUtil unit tests breaking CFG
for next tests.
Finally, I've had to disable the (phpdbg) code-coverage generation, because
it was crashing randomly (php8) and it took a good time for me
to realise that it was the cause of the crashes.
See moodlehq/moodle-plugin-ci#94 about to move to xdebug/pcov.
Fixes #179.