Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply all the standard ignores to the "other" checks #183

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Apply all the standard ignores to the "other" checks #183

merged 2 commits into from
Feb 14, 2022

Commits on Feb 13, 2022

  1. Apply all the standard ignores to the "other" checks 

    When invoking phpcs we pass to it a calculated list of
paths to ignore (substring matching).

That includes all the third part libraries, some directories
like the amd/yui build ones, and the list of exclusions added
in the UI.

It works ok, so far.

But, later, when invoking the "other" checks (an ancient list
of custom checks applied to other files, surely to be removed
some day), we don't apply all those ignores commented above.

This PR just makes those calculated ignores to be also applied to
the "other checks". Covered with tests, it seems to be working ok.

Also, fixes a problem with MoodleUtil unit tests breaking CFG
for next tests.

Fixes moodlehq#179.
    @stronk7
    stronk7 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    942fdb1 View commit details
    Browse the repository at this point in the history

  2. Remove phpdbg code-coverage, it's buggy and crashing randomly 

    We need to move to xdebug/pcov alternatives, see:

moodlehq/moodle-plugin-ci#94
    @stronk7
    stronk7 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    8f8ca5d View commit details
    Browse the repository at this point in the history