Skip to content

Commit

Permalink
DragControls/OrbitControls/TrackballControls: wheel/touchmove/touchst…
Browse files Browse the repository at this point in the history
…art add { passive: false } (#21642)

* DragControls: touchmove/touchstart add { passive: false }

* OrbitControls: wheel/touchmove/touchstart add { passive: false }

* TrackballControls: wheel/touchmove/touchstart add { passive: false }
  • Loading branch information
puxiao committed Apr 13, 2021
1 parent b0500f7 commit 4036a22
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions examples/jsm/controls/DragControls.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ class DragControls extends EventDispatcher {
_domElement.addEventListener( 'pointerdown', onPointerDown );
_domElement.addEventListener( 'pointerup', onPointerCancel );
_domElement.addEventListener( 'pointerleave', onPointerCancel );
_domElement.addEventListener( 'touchmove', onTouchMove );
_domElement.addEventListener( 'touchstart', onTouchStart );
_domElement.addEventListener( 'touchmove', onTouchMove, { passive: false } );
_domElement.addEventListener( 'touchstart', onTouchStart, { passive: false } );
_domElement.addEventListener( 'touchend', onTouchEnd );

}
Expand Down
6 changes: 3 additions & 3 deletions examples/jsm/controls/OrbitControls.js
Original file line number Diff line number Diff line change
Expand Up @@ -1187,11 +1187,11 @@ class OrbitControls extends EventDispatcher {
scope.domElement.addEventListener( 'contextmenu', onContextMenu );

scope.domElement.addEventListener( 'pointerdown', onPointerDown );
scope.domElement.addEventListener( 'wheel', onMouseWheel );
scope.domElement.addEventListener( 'wheel', onMouseWheel, { passive: false } );

scope.domElement.addEventListener( 'touchstart', onTouchStart );
scope.domElement.addEventListener( 'touchstart', onTouchStart, { passive: false } );
scope.domElement.addEventListener( 'touchend', onTouchEnd );
scope.domElement.addEventListener( 'touchmove', onTouchMove );
scope.domElement.addEventListener( 'touchmove', onTouchMove, { passive: false } );

// force an update at start

Expand Down
6 changes: 3 additions & 3 deletions examples/jsm/controls/TrackballControls.js
Original file line number Diff line number Diff line change
Expand Up @@ -725,11 +725,11 @@ class TrackballControls extends EventDispatcher {
this.domElement.addEventListener( 'contextmenu', contextmenu );

this.domElement.addEventListener( 'pointerdown', onPointerDown );
this.domElement.addEventListener( 'wheel', mousewheel );
this.domElement.addEventListener( 'wheel', mousewheel, { passive: false } );

this.domElement.addEventListener( 'touchstart', touchstart );
this.domElement.addEventListener( 'touchstart', touchstart, { passive: false } );
this.domElement.addEventListener( 'touchend', touchend );
this.domElement.addEventListener( 'touchmove', touchmove );
this.domElement.addEventListener( 'touchmove', touchmove, { passive: false } );

this.domElement.ownerDocument.addEventListener( 'pointermove', onPointerMove );
this.domElement.ownerDocument.addEventListener( 'pointerup', onPointerUp );
Expand Down

0 comments on commit 4036a22

Please sign in to comment.