-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decal example is not working #20205
Comments
@Mugen87 I'll have a look at this today. I hope we don't have to revert. |
I ran into similar issues with 0.120.0 where it seemed like the upgrade (probably OrbitControls) ate my mousemove events while panning (i.e. while the mouse button was down I no longer got any mousemove events). When I changed my code to listen to 'pointermove' (as the OrbitControls does) instead of 'mousemove' it started working again. Could it be that if a pointermove eventlistener is triggered, then the browser would not trigger the mousemove event for some reason since they are almost the same? |
It's explain at the MDN: https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent
|
I guess you are referring to this part of the doc?
I thought the event would still be propagated to my event listener since the OrbitControls isn't doing event.stopPropagation but this might explain why i got no mousemove and also why changing to pointermove worked (since I guess that one is still propagated). Interesting, thanks! |
Fixed: 2b477f0 This example also never worked on mobile before either. |
Seems like in order to update to |
@mrdoob have you considered removing the |
@marcofugaro Just because |
@marcofugaro That ended up being not the problem and I didn't pursue the investigation. |
The original decal example is not working anymore on r120: https://threejs.org/examples/#webgl_decals
Nothing happened when clicking on the object, no error reported in console.
The text was updated successfully, but these errors were encountered: