-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert pointer events change for OrbitControls and TrackballControls. #20194
Conversation
I just want to note that this pointerEvents upgrade also broke all controls when using stylus ( switch ( event.pointerType ) {
case 'mouse':
onMouseMove( event );
break;
} I completely and overwhelmingly support transition to pointerEvents. It is an amazing API that will solve most of the unnecessary conditionals when dealing with different input devices and it will make the controls much simpler. It enables developers to write code that works with any pointer device, including the future ones. In my experience, In other words, switching to pointerEvents is great, but it should be done without dealing with |
@mrdoob Since you want to keep the Pointer Events change, I'll close this PR. |
I think a hot patch to r.120 is appropriate. |
It does not appear the hot patch fixed the slider example... |
Still working on a solution: #20223 |
Oh, I see. You didn't revert the recent changes to the controls. That would have made it a trivial hot patch... |
Should be fixed now. |
Fixed #20191.
Fixed #20193.
Fixed #20205.