Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: enable MSAA with WebGLMultisampledRenderTarget without EffectComposer #16895

Closed
wants to merge 8 commits into from

Conversation

aardgoose
Copy link
Contributor

Enables the WebGLMultisampledRenderTarget to target the default framebuffer for the blitFramebuffer operations, removing the need for EffectComposer and the extra copy pass.

example modified to test.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 24, 2019

example modified to test.

The example should demonstrate MSAA in context of postprocessing which is the most relevant use case for WebGLMultisampledRenderTarget.

FYI: If it's a draft PR, then please use the respective github feature:

https://github.blog/2019-02-14-introducing-draft-pull-requests/

What is your case for this change?

@aardgoose
Copy link
Contributor Author

I wasn't aware of the draft feature - rather well hidden.

The point was to allow MSAA without the overhead/complications of the postprocessing framework.

@aardgoose aardgoose closed this Jun 24, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 25, 2019

Oh, why was this closed?

@arpu
Copy link

arpu commented Mar 25, 2021

@aardgoose i am interessierend in this too could you rebase this PR and reopen? or should i open a new one?

@arpu
Copy link

arpu commented Mar 26, 2021

@Mugen87 i tested this patch against r127dev and get
GL_INVALID_OPERATION: Blit feedback loop: the read and draw framebuffers are the same.
would be cool if you could look at this if you have time.

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 26, 2021

This change does not work 1:1 when applied to latest dev since framebuffer management has changed.

I'm also not sure if the directToCanvas property is a good solution...

@arpu
Copy link

arpu commented Mar 26, 2021

for me the most imported part is setting the Hardware MSAA, because Chrome set it to 4x as default still if gl.MAX_SAMPLES is higher ( 8x,16x)

https://bugs.chromium.org/p/chromium/issues/detail?id=1063437

@arpu
Copy link

arpu commented Mar 26, 2021

@Mugen87 maybe i oversee something? is there any other simpler way to set this?

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 4, 2021

GL_INVALID_OPERATION: Blit feedback loop: the read and draw framebuffers are the same.

@arpu This warning should be gone after #21570.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants