Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Add view helper. #19769

Merged
merged 4 commits into from
Jul 1, 2020
Merged

Editor: Add view helper. #19769

merged 4 commits into from
Jul 1, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 1, 2020

This PR adds the view helper to the editor representing the current view of the editor's main camera.

2020-07-01 15 20 35

The design and behavior is similar to Blender's widget. The axes elements are not yet clickable. However, the idea is to implement this feature in order to animate the camera to certain view presets.

The editor renders the widget as an inset view similar to the wide line demos.

@marcofugaro
Copy link
Contributor

marcofugaro commented Jul 1, 2020

Nice!

However the Z is not really distinguishable.
I'd use less saturated colors, blender currently uses #FF3653, #8ADB00 and #2C8FFF.

@mrdoob mrdoob added this to the r119 milestone Jul 1, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jul 1, 2020

I'll merge and tweak.

@mrdoob mrdoob merged commit 6a08232 into mrdoob:dev Jul 1, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jul 1, 2020

Very nice! Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jul 2, 2020

Tweaked:

Screen Shot 2020-07-01 at 7 01 25 PM

Replaced AxesHelper with boxes to emulate line thickness.

@mrdoob
Copy link
Owner

mrdoob commented Jul 2, 2020

I think the colors turned out paler (probably in linear space?) but I kind of like them 😀

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 2, 2020

I'm glad the editor provides such a helper by default now 😊. I've actually seen users in the past who tried implementing something similar for their own editors/viewers but had difficulties to get the UI and math right. I feel this is a nice reference 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants