Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Refactor usage of default camera. #19820

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Editor: Refactor usage of default camera. #19820

merged 1 commit into from
Jul 10, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 9, 2020

The PR slightly refactors the usage of the editor's default camera. It ensures

  • that the fixes of 4abbce4 still work
  • but handles DEFAULT_CAMERA now as a constant
  • it's also a module scope variable now and does not leak anymore in Viewport

This is done by introducing a new signal cameraResetted that notifies Viewport to update the aspect ratio of the editor's camera.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 10, 2020

BTW: I would like to try adding support for an orthographic editor camera similar to Unity's scene editor. This PR and another follow-up change prepare the codebase so it's easier to implement this feature.

@mrdoob mrdoob added this to the r119 milestone Jul 10, 2020
@mrdoob mrdoob merged commit e2b7108 into mrdoob:dev Jul 10, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jul 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants