NodeBuilder: Missing property in requires type definition #19895
Conversation
Signed-off-by: martinRenou <martin.renou@gmail.com>
martinRenou
force-pushed
the
node_builder_requires_type
branch
from
cc6e9b7
to
59ec596
Compare
| @@ -24,6 +24,8 @@ export class NodeBuilder { | |||
| color: boolean[]; | |||
| lights: boolean; | |||
| fog: boolean; | |||
| transparent: boolean; | |||
| irradiance: boolean; | |||
There was a problem hiding this comment.
Yes, it seems to be used here: https://github.com/mrdoob/three.js/blob/dev/examples/jsm/nodes/materials/nodes/StandardNode.js#L229
But there is a big chance I misunderstand something. I don't quite understand this code base and the logic yet.
|
Ahh ok. You can add these properties here: |
Will do! Should their default value be false? |
Yes, yes. This values is really defined in |
|
Ok :) @sunag now that I have a bit of you attention, say I want to discuss with you some features or improvements I would like to push on actual code (not only TypeScript this time). Is there a discourse discussion where we could chat or something equivalent? |
Signed-off-by: martinRenou <martin.renou@gmail.com>
We can use private message of the twitter for chat? You can add me @sea3dformat |
Ahah, great, I followed you a week ago I think. I did not realize @sea3dformat was actually sunag who implemented the amazing NodeMaterials, I would have followed you sooner if I knew :D I am @martinRenou on Twitter, I guess you only can send the first private message (I don't see any button for sending a PM). |
|
@sunag looks good now? |
There was a problem hiding this comment.
@martinRenou Thanks again. Maybe I remove irradiance in the future, I think that this property should have relation only with PBR materials...
Yes, yes 👍 👍 |
|
Thanks! |
Used here for example: https://github.com/mrdoob/three.js/blob/dev/examples/jsm/nodes/materials/nodes/StandardNode.js#L229 and https://github.com/mrdoob/three.js/blob/dev/examples/jsm/nodes/materials/nodes/StandardNode.js#L241
cc. @sunag