Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: add Node Flow interface #19896

Merged
merged 2 commits into from
Jul 22, 2020
Merged

TS: add Node Flow interface #19896

merged 2 commits into from
Jul 22, 2020

Conversation

martinRenou
Copy link
Contributor

cc. @sunag

@martinRenou
Node: Add Flow interface
72d04b6 
Signed-off-by: martinRenou <martin.renou@gmail.com>
@mrdoob mrdoob requested a review from sunag July 21, 2020 13:06
@mrdoob mrdoob added this to the r119 milestone Jul 21, 2020
sunag
sunag requested changes Jul 22, 2020
View reviewed changes
examples/jsm/nodes/core/Node.d.ts Outdated Show resolved Hide resolved
@sunag sunag self-requested a review July 22, 2020 11:41
sunag
sunag approved these changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@sunag sunag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mrdoob mrdoob merged commit 5936665 into mrdoob:dev Jul 22, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jul 22, 2020

Double thanks!

@martinRenou martinRenou deleted the node_flow branch July 22, 2020 11:50
@WestLangley WestLangley changed the title Node: Add Flow interface TS: add Node Flow interface Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunag sunag sunag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r119
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @mrdoob @sunag