Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: generalize NodeMaterial vertex/fragment types #19897

Merged
merged 1 commit into from
Jul 22, 2020
Merged

TS: generalize NodeMaterial vertex/fragment types #19897

merged 1 commit into from
Jul 22, 2020
+4 −4

Conversation

martinRenou
Copy link
Contributor

Generalize the constructor args types for the NodeMaterial class.

Please tell me if I am not correct, but taking a MeshStandardNode seems wrong anyway, as the StandardNodeMaterial class (which inherits from NodeMaterial) passes a StandardNode instance there, which does not inherit from MeshStandardNode.

cc. @sunag

@martinRenou
NodeMaterial: Generalize the vertex/fragment types
c4f701d 
Signed-off-by: martinRenou <martin.renou@gmail.com>
@mrdoob mrdoob requested a review from sunag July 21, 2020 13:06
@mrdoob mrdoob added this to the r119 milestone Jul 21, 2020
sunag
sunag approved these changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@sunag sunag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mrdoob mrdoob merged commit 8bc2f1c into mrdoob:dev Jul 22, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jul 22, 2020

Thanks indeed!

@martinRenou martinRenou deleted the nodematerial_vertex_fragment_type branch July 22, 2020 11:43
@martinRenou
Copy link
Contributor Author

Thank you for merging so quickly :)

@WestLangley WestLangley changed the title NodeMaterial: Generalize the vertex/fragment types TS: generalize NodeMaterial vertex/fragment types Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunag sunag sunag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r119
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @mrdoob @sunag