-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make equirectangular reflections / refractions backwards compatible. #19911
Merged
Merged
Changes from 14 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e52d7cb
Remove Equirect Reflection/Refraction Mapping
WestLangley 895b78f
Merge branch 'dev_equirect_refl_mapping' of https://github.com/WestLa…
mrdoob 6c5a7f2
Reverted EquirectangularReflectionMapping and EquirectangularRefracti…
mrdoob 95b43cd
Added EquirectangularTexture and EquirectangularTextureLoader.
mrdoob 23e0192
WebGLCubeRenderTarget: Avoid using renderer.render() in fromEquirecta…
mrdoob ddd9a46
WebGLBackground: Support EquirectangularTextures as background.
mrdoob 74e4d98
Examples: Simplified webgl_materials_envmaps example.
mrdoob d50a5f0
Fixed EquirectangularTextureLoader.d.ts
mrdoob d6bc2e8
Removed EquirectangularTextureLoader
mrdoob 88c1757
WebGLBackground: Fixed breaking when using Color as background.
mrdoob dbd0646
Examples: Fixed FBXLoader and LWOLoader.
mrdoob 9e8588d
WebGLTextures: Moved cubeTexture code to its own class.
mrdoob 99ca2b3
WebGLCubeMaps: Handle CubeUVReflectionMapping and CubeUVRefractionMap…
mrdoob 36d2384
WebGLCubeRenderTarget: Renamed isWebGLCubeTexture hack to isWebGLCube…
mrdoob 48df1ea
Removed EquirectangularTexture
mrdoob 108a399
WebGLCubeMaps: Simplified and fixed some breakage.
mrdoob 1526e83
Reverted more removals.
mrdoob f601b75
Merge branch 'dev' into dev_equirect_refl_mapping
mrdoob f3adff7
WebGLRenderer: Check object.geometry before updating attributes.
mrdoob 99a6e91
WebGLRenderer: Added getRenderList and setRenderList.
mrdoob 833b170
WebGLBackground: Added WebGLCubeRenderTarget support back.
mrdoob c005069
Reverted comment removal.
mrdoob f25ccec
WebGLCubeRenderTarget: Avoid using mipmaps in fromEquirectangularText…
mrdoob c40361a
WebGLCubeRenderTarget: Reverted generateMipmaps/migFilter/magFilter r…
mrdoob 271bdb2
WebGLCubeMaps: Added DataTexture support.
mrdoob e638a1d
Examples: Added more detail to sphere in webgl_materials_envmap.
mrdoob 8e7bcf2
WebGLCubeRenderTarget: Improved LinearMipmapLinearFilter handling.
mrdoob 7024543
WebGLCubeMaps: Added support for CompressedTextures.
mrdoob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this means
generateMipmaps
will always befalse
and thus usingLinearMipmapLinearFilter
is invalid. Is this intended?This will break existing code (
webgl_materials_cubemap_dynamic
) that used to generate the background like so:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this particular case.... I don't think we need mipmaps for the background? 🤔