Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UASTC to BC7 target format selection #19916

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Fix UASTC to BC7 target format selection #19916

merged 1 commit into from
Jul 23, 2020

Conversation

lexaknyazev
Copy link
Contributor

Current code tries to access BC7_M6_RGB without a proper namespace and fails. Moreover, there's no need to check alpha presence for UASTC to BC7 transcoding.

FWIW, the proper enum name should be BC7_RGBA but it's not exposed yet.

/cc @donmccurdy

@mrdoob mrdoob requested a review from donmccurdy July 23, 2020 15:32
@mrdoob mrdoob added this to the r119 milestone Jul 23, 2020
donmccurdy
donmccurdy approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@donmccurdy donmccurdy merged commit 4a8c4ae into mrdoob:dev Jul 23, 2020
@lexaknyazev lexaknyazev deleted the patch-1 branch July 23, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r119
Development

Successfully merging this pull request may close these issues.
3 participants
@lexaknyazev @donmccurdy @mrdoob