Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object3D: correctly update world matrix prior to use #19969

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Object3D: correctly update world matrix prior to use #19969

merged 1 commit into from
Sep 1, 2020
+4 −4

Conversation

WestLangley
Copy link
Collaborator

Fixes #19962.

Reimplementation of #16292.

@WestLangley WestLangley added this to the r120 milestone Jul 31, 2020
@yomotsu yomotsu mentioned this pull request Aug 2, 2020
Closed
@mrdoob mrdoob modified the milestones: r120, r121 Aug 25, 2020
@WestLangley WestLangley changed the title Object3D: updateMatrixWorld() -> updateWorldMatrix() Object3D: correctly update world matrix prior to use Aug 29, 2020
@WestLangley
Copy link
Collaborator Author

I think the former title was misleading... Changed it.

@mrdoob mrdoob merged commit e4ecd3e into mrdoob:dev Sep 1, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 1, 2020

Thanks!

@WestLangley WestLangley deleted the dev_update_world_matrix branch September 2, 2020 00:24
This was referenced Oct 1, 2020
Merged
Closed
@Mugen87 Mugen87 mentioned this pull request Mar 4, 2021
Closed
@acu192 acu192 mentioned this pull request Apr 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r121
Development

Successfully merging this pull request may close these issues.

Object3D.getWorld*() should call updateWorldMatrix(true) instead of updateMatrixWorld(true) ?
3 participants
@WestLangley @mrdoob @Mugen87