Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLCubeMaps: Fix runtime error when image is undefined. #20043

Merged
merged 1 commit into from
Aug 10, 2020
Merged

WebGLCubeMaps: Fix runtime error when image is undefined. #20043

merged 1 commit into from
Aug 10, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 10, 2020

@mrdoob mrdoob added this to the r120 milestone Aug 10, 2020
@mrdoob mrdoob merged commit 4bb1b01 into mrdoob:dev Aug 10, 2020
@mrdoob
Copy link
Owner

mrdoob commented Aug 10, 2020

Thanks!

@WestLangley
Copy link
Collaborator

WestLangley commented Aug 10, 2020 •
edited
Loading

This PR requires a new build.

With this PR, I am getting

three.module.js:17794 WebGL: INVALID_OPERATION: uniformMatrix4fv: location is not from current program

This may be helpful: to reproduce in webgl_materials_envmaps.html, start with the equirectangular texture, instead:

sphereMaterial = new THREE.MeshPhongMaterial( { envMap: textureEquirec } );

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Aug 11, 2020

I've only tested with Scene.background. I'll have a look...

@Mugen87 Mugen87 mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r120
Development

Successfully merging this pull request may close these issues.
3 participants
@Mugen87 @mrdoob @WestLangley