Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: Added types for WebXR #20150

Merged
merged 6 commits into from
Sep 18, 2020
Merged

TS: Added types for WebXR #20150

merged 6 commits into from
Sep 18, 2020

Conversation

repalash
Copy link
Contributor

Added types for WebXR and fixed object types in WebXR related declaration files.
Related to issue #20041

Types are adapted from these files.

@repalash repalash mentioned this pull request Aug 21, 2020
2 tasks
@mrdoob
Copy link
Owner

mrdoob commented Aug 23, 2020

I think I would move the file to src/renderers/webxr/webxr.d.ts.

@mrdoob mrdoob added this to the r120 milestone Aug 23, 2020
@repalash
Copy link
Contributor Author

@mrdoob I figured since it doesn't declare types for any three.js specific module, it should be put it extras. Do you think I should move it to src/renderers/webxr?

Also, I haven't exported these types in Three.d.ts, should that be done? Would it be useful?

@mrdoob
Copy link
Owner

mrdoob commented Aug 25, 2020

@mrdoob I figured since it doesn't declare types for any three.js specific module, it should be put it extras. Do you think I should move it to src/renderers/webxr?

I think so yes.

Also, I haven't exported these types in Three.d.ts, should that be done? Would it be useful?

No idea, I have no experience with Typescript...

@mrdoob mrdoob modified the milestones: r120, r121 Aug 25, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 17, 2020

Looking good!

Just a few linting warnings. Are these fixable?
https://github.com/mrdoob/three.js/pull/20150/files

@repalash
Copy link
Contributor Author

Yeah, fixed.

@mrdoob mrdoob changed the title Added types for WebXR TS: Added types for WebXR Sep 18, 2020
@mrdoob mrdoob merged commit 5999fac into mrdoob:dev Sep 18, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 18, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants