Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use single quotes. #20185

Merged
merged 1 commit into from
Aug 25, 2020
Merged

src: use single quotes. #20185

merged 1 commit into from
Aug 25, 2020

Conversation

linbingquan
Copy link
Contributor

No description provided.

@linbingquan
Copy link
Contributor Author

I have a question, how to make sure the source code use single quotes when we are coding?

@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 25, 2020

I guess that auto-generated imports are responsible for the double-quotes. This is normally an editor/IDE setting.

@mrdoob mrdoob added this to the r120 milestone Aug 25, 2020
@mrdoob mrdoob merged commit e139603 into mrdoob:dev Aug 25, 2020
@mrdoob
Copy link
Owner

mrdoob commented Aug 25, 2020

Thanks!

@DefinitelyMaybe
Copy link
Contributor

ooo, interesting. anyone know the eslint rule for making thing's single quotes? we could add it in to package.json

@linbingquan linbingquan deleted the dev-cleanup-src branch September 25, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r120
Development

Successfully merging this pull request may close these issues.
4 participants
@linbingquan @Mugen87 @mrdoob @DefinitelyMaybe