TS: Added undefined as .defines member

[ycw]

.defines is not declared at https://github.com/mrdoob/three.js/blob/dev/src/materials/Material.js, so it is optional.

[Mugen87]

This should be safe since all materials which actually set defines like MeshStandardMaterial overwrite the type declaration in their own TS file with:

defines: { [key: string]: any };

So property access in context of those materials should not break.

[ycw]

It would be better modeling the type exactly for that .js unless the item is internal.
for this case Material is exported (not internal), one can class MyMaterial extends Material {} in TS.

this.defines['x'] = 0; // passed typecheck, fail at runtime.

[Mugen87]

How about defining defines in Material.js like so:

this.defines = {};

In this way, it would be never undefined. An we could delete all type declarations of defines in derived materials (e.g. ShaderMaterial).

[ycw]

How about defining defines in Material.js like so:

this.defines = {};

In this way, it would be never undefined. An we could delete all type declarations of defines in derived materials (e.g. ShaderMaterial).

This will make those derived materials (point, sprite, shadow..) bloated.

[Mugen87]

What do you mean with "bloated"? Do you mind explaining in more detail?

[ycw]

What do you mean with "bloated"? Do you mind explaining in more detail?

After adding .defines = {} to Material.js; it is fine from shadermaterial POV as it needs this property.
But for those derived materials like pointsmaterial, spritematerial, shadowmaterial etc,
they own a .defines (an empty js object) which is never be used.

[Mugen87]

But this also true for other common material properties. E.g. vertexColors or flatShading is not use by all materials.

[ycw]

But this also true for other common material properties. E.g. vertexColors or flatShading is not use by all materials.

I've no idea why those props are existing there.

[mrdoob]

Thanks!