Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Updated Quaternion.setFromRotationMatrix() to specify the matrix needs to be pure #20396

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Doc: Updated Quaternion.setFromRotationMatrix() to specify the matrix needs to be pure #20396

merged 2 commits into from
Oct 12, 2020

Conversation

FlorentMasson
Copy link
Contributor

@FlorentMasson FlorentMasson commented Sep 22, 2020 •
edited by Mugen87
Loading

Related issues:

Fixed #20391

Description

Update doc for Quaternion.setFromRotationMatrix() to specify the matrix needs to be pure

@mrdoob mrdoob added this to the r121 milestone Sep 22, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 22, 2020

@WestLangley sounds good to you?

@mrdoob mrdoob modified the milestones: r121, r122 Sep 29, 2020
@mrdoob mrdoob changed the title Update doc for Quaternion.setFromRotationMatrix() to specify the matrix needs to be pure Doc: Updated Quaternion.setFromRotationMatrix() to specify the matrix needs to be pure Oct 12, 2020
@mrdoob mrdoob merged commit bf27a80 into mrdoob:dev Oct 12, 2020
@mrdoob
Copy link
Owner

mrdoob commented Oct 12, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r122
Development

Successfully merging this pull request may close these issues.

Update unclear doc for Quaternion.setFromRotationMatrix()
3 participants
@FlorentMasson @mrdoob @Mugen87