Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometries: Clean up TS files. #20426

Merged
merged 11 commits into from
Sep 28, 2020
Merged

Geometries: Clean up TS files. #20426

merged 11 commits into from
Sep 28, 2020
+23 −25

Conversation

klevron
Copy link
Sponsor Contributor

@klevron klevron commented Sep 28, 2020

Description

Fix a little typo in param comment for thetaLength

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 28, 2020

Can you please also fix this for CylinderGeometry.d.ts?

@Mugen87 Mugen87 changed the title fix param comment for thetaLength TS: Fix param comment for thetaLength in CylinderGeometry. Sep 28, 2020
@klevron
Copy link
Sponsor Contributor Author

klevron commented Sep 28, 2020

Ok, done, and added a fix for Cone

@Mugen87 Mugen87 changed the title TS: Fix param comment for thetaLength in CylinderGeometry. Geometries: Clean up TS files. Sep 28, 2020
@klevron
Copy link
Sponsor Contributor Author

klevron commented Sep 28, 2020

Done, sorry for the multiple commits

@mrdoob mrdoob added this to the r121 milestone Sep 28, 2020
@mrdoob mrdoob merged commit abedf8c into mrdoob:dev Sep 28, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 28, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r121
Development

Successfully merging this pull request may close these issues.
3 participants
@klevron @Mugen87 @mrdoob