Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: Add 3D LUT Color Grading Postprocessing Pass #20558

Merged
merged 10 commits into from
Oct 26, 2020

Conversation

gkjohnson
Copy link
Collaborator

Fix #19457.

This PR adds file format loads for CUBE and 3DL 3D Color LUT files (both of which can be exported from photoshop and other applications) as well as LUTPass for postprocessing and an associated example. The loaders generate both 2D and 3D data textures which LUTPass can use which means it supports both WebGL1 and 2.

The LUTs used in the demo are provided free from RocketStock.com which I've added an attribution for at the top of the example.

Here's the example page from this PR:

https://raw.githack.com/gkjohnson/three.js/lut-pass/examples/webgl_postprocessing_3dlut.html

And here's the demo I originally made in another repo that uses a photograph and quite a few other LUTs for demonstration:

https://gkjohnson.github.io/threejs-sandbox/3d-lut/

@gkjohnson
Copy link
Collaborator Author

When I generate a screenshot it all looks black 🤔 not sure why that is. Have I structured something wrong in the example for taking screenshots?

webgl_postprocessing_3dlut

@mrdoob
Copy link
Owner

mrdoob commented Oct 26, 2020

Beautiful! We should rename these to InstaFilterLoader 😁

@mrdoob mrdoob added this to the r122 milestone Oct 26, 2020
@mrdoob mrdoob merged commit a3350bf into mrdoob:dev Oct 26, 2020
@mrdoob
Copy link
Owner

mrdoob commented Oct 26, 2020

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Oct 26, 2020

When I generate a screenshot it all looks black 🤔 not sure why that is. Have I structured something wrong in the example for taking screenshots?

No idea...
I've just ran npm run make-screenshot webgl_postprocessing_3dlut locally and it generated a good screenshot 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add support for 3DLUT color grading
2 participants