Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples/webgl_gpgpu_birds_gltf.html cohesion 0 error #20649

Merged
merged 3 commits into from
Nov 10, 2020

Conversation

gonnavis
Copy link
Contributor

@gonnavis gonnavis commented Nov 9, 2020

https://threejs.org/examples/?q=webgl_gpgpu_birds_gltf#webgl_gpgpu_birds_gltf

Set gui cohesion to 0 will cause all birds dissaper and can't go back, because of when just set cohesion to 0 will let the divisor threshDelta to be 0.

@gonnavis gonnavis changed the title Fix webgl_gpgpu_birds_gltf cohesion 0 error Fix examples/webgl_gpgpu_birds_gltf.html cohesion 0 error Nov 9, 2020
@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 9, 2020

Sidenode: Do we really need two GPGPU birds examples? To me, the orignial (more minimalistic) webgl_gpgpu_birds is still the best.

BTW: This issue also exists in webgl_gpgpu_birds.

@gonnavis
Copy link
Contributor Author

gonnavis commented Nov 9, 2020

Sidenode: Do we really need two GPGPU birds examples? To me, the orignial (more minimalistic) webgl_gpgpu_birds is still the best.

I think they all useful because one is creating the geometry from the scratch, and another from loaded gltf and containing animation.
I'm preparing to make a project based on webgl_gpgpu_birds_gltf.html.

BTW: This issue also exists in webgl_gpgpu_birds.

I intended to modify the webgl_gpgpu_birds if this change is correct.

@marcofugaro
Copy link
Contributor

Sidenode: Do we really need two GPGPU birds examples? To me, the orignial (more minimalistic) webgl_gpgpu_birds is still the best.

This example was also useful to me in the past to see how to handle custom geometry with custom positions (all of the BufferAttribute stuff)

@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 9, 2020

This example was also useful to me in the past to see how to handle custom geometry with custom positions (all of the BufferAttribute stuff)

AFAIK, we do have other examples that are focused on the usage of BufferGeometry.

@mrdoob mrdoob added this to the r123 milestone Nov 10, 2020
@mrdoob
Copy link
Owner

mrdoob commented Nov 10, 2020

Sidenode: Do we really need two GPGPU birds examples? To me, the orignial (more minimalistic) webgl_gpgpu_birds is still the best.

I think the examples are different enough, but I sure want to do some clean up in webgl_gpgpu_birds_gltf 😬

@mrdoob mrdoob merged commit 6e7f347 into mrdoob:dev Nov 10, 2020
@mrdoob
Copy link
Owner

mrdoob commented Nov 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants