Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Ensure material selection fits to object type. #20710

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Editor: Ensure material selection fits to object type. #20710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 54 additions & 20 deletions editor/js/Sidebar.Material.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,26 +60,7 @@ function SidebarMaterial( editor ) {
// type

var materialClassRow = new UIRow();
var materialClass = new UISelect().setOptions( {

'LineBasicMaterial': 'LineBasicMaterial',
'LineDashedMaterial': 'LineDashedMaterial',
'MeshBasicMaterial': 'MeshBasicMaterial',
'MeshDepthMaterial': 'MeshDepthMaterial',
'MeshNormalMaterial': 'MeshNormalMaterial',
'MeshLambertMaterial': 'MeshLambertMaterial',
'MeshMatcapMaterial': 'MeshMatcapMaterial',
'MeshPhongMaterial': 'MeshPhongMaterial',
'MeshToonMaterial': 'MeshToonMaterial',
'MeshStandardMaterial': 'MeshStandardMaterial',
'MeshPhysicalMaterial': 'MeshPhysicalMaterial',
'RawShaderMaterial': 'RawShaderMaterial',
'ShaderMaterial': 'ShaderMaterial',
'ShadowMaterial': 'ShadowMaterial',
'SpriteMaterial': 'SpriteMaterial',
'PointsMaterial': 'PointsMaterial'

} ).setWidth( '150px' ).setFontSize( '12px' ).onChange( update );
var materialClass = new UISelect().setWidth( '150px' ).setFontSize( '12px' ).onChange( update );

materialClassRow.add( new UIText( strings.getKey( 'sidebar/material/type' ) ).setWidth( '90px' ) );
materialClassRow.add( materialClass );
Expand Down Expand Up @@ -1365,8 +1346,27 @@ function SidebarMaterial( editor ) {

}

if ( currentObject.isMesh ) {

materialClass.setOptions( meshMaterialOptions );

} else if ( currentObject.isSprite ) {

materialClass.setOptions( spriteMaterialOptions );

} else if ( currentObject.isPoints ) {

materialClass.setOptions( pointsMaterialOptions );

} else if ( currentObject.isLine ) {

lineMaterialOptions.setOptions( lineMaterialOptions );

}

materialClass.setValue( material.type );


if ( material.color !== undefined ) {

materialColor.setHexValue( material.color.getHexString() );
Expand Down Expand Up @@ -1759,6 +1759,40 @@ function SidebarMaterial( editor ) {
'attribute vec3 position;\n\n',
].join( '\n' );

var meshMaterialOptions = {
'MeshBasicMaterial': 'MeshBasicMaterial',
'MeshDepthMaterial': 'MeshDepthMaterial',
'MeshNormalMaterial': 'MeshNormalMaterial',
'MeshLambertMaterial': 'MeshLambertMaterial',
'MeshMatcapMaterial': 'MeshMatcapMaterial',
'MeshPhongMaterial': 'MeshPhongMaterial',
'MeshToonMaterial': 'MeshToonMaterial',
'MeshStandardMaterial': 'MeshStandardMaterial',
'MeshPhysicalMaterial': 'MeshPhysicalMaterial',
'RawShaderMaterial': 'RawShaderMaterial',
'ShaderMaterial': 'ShaderMaterial',
'ShadowMaterial': 'ShadowMaterial'
};

var lineMaterialOptions = {
'LineBasicMaterial': 'LineBasicMaterial',
'LineDashedMaterial': 'LineDashedMaterial',
'RawShaderMaterial': 'RawShaderMaterial',
'ShaderMaterial': 'ShaderMaterial'
};

var spriteMaterialOptions = {
'SpriteMaterial': 'SpriteMaterial',
'RawShaderMaterial': 'RawShaderMaterial',
'ShaderMaterial': 'ShaderMaterial'
};

var pointsMaterialOptions = {
'PointsMaterial': 'PointsMaterial',
'RawShaderMaterial': 'RawShaderMaterial',
'ShaderMaterial': 'ShaderMaterial'
};

return container;

}
Expand Down