Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Implemented es6 default parameters. #20749

Merged
merged 1 commit into from
Nov 24, 2020
Merged

src: Implemented es6 default parameters. #20749

merged 1 commit into from
Nov 24, 2020

Conversation

linbingquan
Copy link
Contributor

Description

  1. Followup of 00f2725

  2. Keep it order

  3. Removed some parameters looks odd.

Please to review it and tell me where has some wrong.

@mrdoob mrdoob added this to the r123 milestone Nov 24, 2020
@mrdoob mrdoob merged commit 3bd91ca into mrdoob:dev Nov 24, 2020
@mrdoob
Copy link
Owner

mrdoob commented Nov 24, 2020

Thanks!

@linbingquan linbingquan deleted the dev-src-es6-default-value branch February 28, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r123
Development

Successfully merging this pull request may close these issues.
3 participants
@linbingquan @mrdoob @Mugen87