Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More detailed error messages when using invalid object types. #20912

Merged
merged 2 commits into from
Dec 21, 2020
Merged

More detailed error messages when using invalid object types. #20912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
227b45b
Raycaster: Display the type of camera that is not supported.
1993heqiang Dec 20, 2020
6f7b07a
Simplified writing
1993heqiang Dec 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/js/loaders/GLTFLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ THREE.GLTFLoader = ( function () {
break;

default:
throw new Error( 'THREE.GLTFLoader: Unexpected light type, "' + lightDef.type + '".' );
throw new Error( 'THREE.GLTFLoader: Unexpected light type: ' + lightDef.type );

}

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/loaders/GLTFLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ var GLTFLoader = ( function () {
break;

default:
throw new Error( 'THREE.GLTFLoader: Unexpected light type, "' + lightDef.type + '".' );
throw new Error( 'THREE.GLTFLoader: Unexpected light type: ' + lightDef.type );

}

Expand Down
2 changes: 1 addition & 1 deletion src/core/Raycaster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Object.assign( Raycaster.prototype, {

} else {

console.error( 'THREE.Raycaster: Unsupported camera type.' );
console.error( 'THREE.Raycaster: Unsupported camera type: ' + camera.type );

}

Expand Down