LDrawLoader: Fix uniforms to support fog #20913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed uniforms of conditionalEdgeMaterial to support fog. I think this is a bug, because its VertShader and FragShader are already support fog.
Fixed uniforms of conditionalEdgeMaterial to support fog. I think this is a bug, because its VertShader and FragShader is already support fog.
|
@yomboprime looks good? |
|
Looks good to me -- not including the fog uniforms was just an oversight when I added the conditional edges material. Here's a before and after with the model completely faded by fog. Before
After
|
gkjohnson
approved these changes
Dec 21, 2020
|
Thanks! |
|
I saw this two hours ago but was on mobile, impossible to read the diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed uniforms of conditionalEdgeMaterial to support fog.
I think this is a bug, because its VertShader and FragShader are already support fog.