-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved THREE.Geometry out of core. #21031
Conversation
|
# Conflicts: # examples/js/geometries/ConvexGeometry.js # examples/jsm/geometries/ConvexGeometry.js # src/Three.Legacy.js # test/unit/src/core/Geometry.tests.js
The main thing left in this PR are the modifiers and I think the sanest thing to do is to convert them to use Won't be able to work on that until Monday though. |
Um, not sure how easy that is. For some modifiers, we should maybe consider if other data structures like a half edge data structure could make sense. For simplicity, you probably want to convert calls from |
During my tests I have noticed one issue: There is now I would introduce something like |
# Conflicts: # examples/jsm/modifiers/SubdivisionModifier.js # examples/jsm/modifiers/TessellateModifier.js # src/core/DirectGeometry.d.ts
@Mugen87 🙌 🙌 🙌 |
This is exciting! We've worked so long so it's possible to do this step! Glad to see we've made it! 🙌 |
FYI: I've setup a forum topic to inform the community about this change: https://discourse.threejs.org/t/three-geometry-will-be-removed-from-core-with-r125/22401 |
Geometry deprecation ,i want to get vertices, faces, faceVertexUvs from bufferGeometry,Is there any other good way? |
@GGmemeda Please use the forum for help requests. Similar questions like the following one were already answered there: https://discourse.threejs.org/t/facevertexuvs-for-buffergeometry/23040 |
@mrdoob I think that's not possible to change wiki with a PR, so a little note here: Same applies to:
|
Thanks for the feedback. I've clean up the Wiki pages. |
Moved
Geometry
toexamples/jsm/deprecated
.Moved
DirectGeometry
inside ofGeometry
and addedtoBufferGeometry()
inGeometry
.