Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: Improved Skeleton and SkeletonUtils types #21051

Merged
merged 2 commits into from
Jan 14, 2021
Merged

TS: Improved Skeleton and SkeletonUtils types #21051

merged 2 commits into from
Jan 14, 2021
+2 −2

Conversation

maccesch
Copy link
Contributor

@maccesch maccesch commented Jan 10, 2021 •
edited
Loading

Skeleton.calculateInverses() wrongly required an argument.

SekeltonUtils.clone() is more accurately typed as overloaded functions.

@mrdoob mrdoob added this to the r125 milestone Jan 13, 2021
Mugen87
Mugen87 approved these changes Jan 14, 2021
View reviewed changes
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the code. Should be good to go now!

@mrdoob mrdoob changed the title Small fixes to typings TS: Improved Skeleton and SkeletonUtils types Jan 14, 2021
@mrdoob mrdoob merged commit d4f4923 into mrdoob:dev Jan 14, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 14, 2021

Thanks!

@maccesch
Copy link
Contributor Author

I've updated the code. Should be good to go now!

Thanks! Sorry for the late response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r125
Development

Successfully merging this pull request may close these issues.
3 participants
@maccesch @mrdoob @Mugen87