Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Fix contact shadow example #21063

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Conversation

marcofugaro
Copy link
Contributor

@marcofugaro marcofugaro commented Jan 11, 2021

Related issue: #20849 (comment)

Description

With the polygonOffset sorting method the fillPlane was not being shown. By using renderOrder we make sure the shadow plane is on top while still showing the fillPlane.

https://raw.githack.com/marcofugaro/three.js/contact-shadow-fix/examples/webgl_shadow_contact.html

Before After
Screenshot 2021-01-11 at 21 11 23 Screenshot 2021-01-11 at 21 31 08

@marcofugaro marcofugaro changed the title Examples: Fix contect shadow example Examples: Fix contact shadow example Jan 11, 2021
@mrdoob mrdoob added this to the r125 milestone Jan 12, 2021
@mrdoob mrdoob merged commit 81c13ce into mrdoob:dev Jan 12, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 12, 2021

Thanks!

@marcofugaro marcofugaro deleted the contact-shadow-fix branch January 12, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants