GLTFLoader: Fix bug when loading external WebP texture #21282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
reviewed
Feb 15, 2021
# Conflicts: # examples/js/loaders/GLTFLoader.js # examples/jsm/loaders/GLTFLoader.js
donmccurdy
reviewed
Feb 15, 2021
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: --
Description
When loading an external WebP texture file with GLTFLoader and a texture loader is not retrieved with
manager.getHandlerthe loader variable is set to null resulting in an exception. To address it I've changed the logic to mirror what happens in the non-WebP loadTexture function. I found this when looking into a privately shared set of data provided to me to debug an issue with the 3DTilesRendererJS package so unfortunately I cannot share a file for testing but hopefully the logic issue is clear.cc @donmccurdy