Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material: Honor missing properties in toJSON() and MaterialLoader. #21428

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Material: Honor missing properties in toJSON() and MaterialLoader. #21428

merged 2 commits into from
Mar 18, 2021

Conversation

frading
Copy link
Contributor

@frading frading commented Mar 7, 2021 •
edited by Mugen87
Loading

this adds colorWrite to MaterialLoader, and shadowSide to both MaterialLoader and material.toJSON()

Description

  • material.shadowSide was missing from material.toJSON() and MaterialLoader
  • material.colorWrite was missing from material.toJSON()

Mugen87
Mugen87 reviewed Mar 7, 2021
View reviewed changes
src/materials/Material.js Outdated Show resolved Hide resolved
@Mugen87 Mugen87 added this to the r127 milestone Mar 15, 2021
@Mugen87 Mugen87 changed the title add colorWrite to MaterialLoader, and shadowSide to both MaterialLoad… Material: Honor shadowSide in toJSON() and MaterialLoader. Mar 15, 2021
@Mugen87 Mugen87 changed the title Material: Honor shadowSide in toJSON() and MaterialLoader. Material: Honor missing properties in toJSON() and MaterialLoader. Mar 15, 2021
@Mugen87 Mugen87 merged commit bd035ab into mrdoob:dev Mar 18, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 18, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r127
Development

Successfully merging this pull request may close these issues.
3 participants
@frading @mrdoob @Mugen87