Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSRPass: Correct Reflector depth 2. #21537

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

gonnavis
Copy link
Contributor

@gonnavis gonnavis commented Mar 28, 2021

Turned out that this problem is caused by inconsistent virtualCamera.projectionMatrix and virtualCamera.projectionMatrixInverse.

Because of projectionMatrix is copied from camera, so need use camera's projectionMatrixInverse too. No need worldYBias now.

This also solved slight worldY change problem when rotating, and solved the newly found more severe change problem when pan, all caused by the same reason.

before vs after ( try pan the scene )

@Mugen87 Mugen87 added this to the r127 milestone Mar 29, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 29, 2021

Sweet!

@mrdoob mrdoob merged commit 1c5ca1d into mrdoob:dev Mar 29, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 29, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants