Run build-examples #21588
Merged
Run build-examples #21588
+62,649
−57,556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Apr 6, 2021
|
FYI: The additional lgtm errors are produced since |
|
Thanks! |
|
@marcofugaro @Mugen87 @mrdoob this PR added a /js version of the 3dmLoader. Was this the intention? 3dmLoader was developed as a jsm-first/only loader 😎. |
|
@fraguada |
|
That's rad. I was refactoring the jsm version and was wondering about the js version. I'll leave it as it then and let the build tools work their magic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #21584
Description
Run the build-examples script introduced in #21584.