Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDrawLoader: Remove 'var' completely #21620

Merged
merged 5 commits into from
Apr 9, 2021
Merged

LDrawLoader: Remove 'var' completely #21620

merged 5 commits into from
Apr 9, 2021

Conversation

yomboprime
Copy link
Collaborator

@yomboprime yomboprime commented Apr 9, 2021

Related issue: -
Related PR: #21616

Description

Remove the use of var in LDrawLoader and substitute with const and let.

There were no scope issues except inside a switch, where I've decided to move all common named variables declarations just before the switch.

Tested and everything works Ok.

@Mugen87 Mugen87 added this to the r128 milestone Apr 9, 2021
@mrdoob mrdoob merged commit 80317f2 into mrdoob:dev Apr 9, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 9, 2021

Thanks!

@yomboprime yomboprime deleted the remove_var_ldraw branch April 12, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants