Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLNodes: Fix expected behavior .colorNode (WebGPU based) #21692

Merged
merged 1 commit into from
Apr 21, 2021
Merged

WebGLNodes: Fix expected behavior .colorNode (WebGPU based) #21692

merged 1 commit into from
Apr 21, 2021

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Apr 21, 2021

Description

If defined Material.colorNode should override the Material.map and Material.color values as defined in WebGPU.

Related

#21322 (comment)

@Mugen87 Mugen87 added this to the r128 milestone Apr 21, 2021
@mrdoob mrdoob merged commit 60280be into mrdoob:dev Apr 21, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 21, 2021

Thanks!

@sunag sunag deleted the dev-nodematerial-webgl-1 branch April 21, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r128
Development

Successfully merging this pull request may close these issues.
3 participants
@sunag @mrdoob @Mugen87