Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring dat.gui inside vr #21700

Merged
merged 8 commits into from
Apr 23, 2021
Merged

Bring dat.gui inside vr #21700

merged 8 commits into from
Apr 23, 2021

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Apr 22, 2021

Description

More work on bringing interactive HTML elements inside VR.

Screenshot 2021-04-22 at 10 53 55

Live link: https://raw.githack.com/mrdoob/three.js/webxr/examples/webxr_vr_sandbox.html

@mrdoob mrdoob added this to the r128 milestone Apr 22, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 22, 2021

Tested this on a Oculus Quest (1) and the interaction works fine! The only thing I have notice is that the labels of the GUI are somewhat hard to read from a steep angle. The text gets more sharp if I move my position in front of the GUI.

Would it makes sense to orient the plane always towards the VR camera's position?

@mrdoob
Copy link
Owner Author

mrdoob commented Apr 22, 2021

Would it makes sense to orient the plane always towards the VR camera's position?

I'm planning on making these panels grabbable.
So we can grab it with one hand and mode the sliders with the other 🤓

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 22, 2021

That should definitely help^^.

@gkjohnson
Copy link
Collaborator

Looks great! I was looking for something like this awhile ago. My only comment is that the name InteractionManager feels a little generic. Maybe XRInteractionManager to be consistent with the other XR classes? Or something related to the event forwarding it does like XRInteractionDispatcher? Either way I'm excited to see this.

@mrdoob
Copy link
Owner Author

mrdoob commented Apr 22, 2021

@gkjohnson I was on the middle of a complete API redesign 😅
Would you like to have another look? (I'll add pointer events next)

@mrdoob mrdoob merged commit e9f910c into dev Apr 23, 2021
@mrdoob mrdoob deleted the webxr branch April 23, 2021 08:39
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 23, 2021

Tested the demo on dev today again and it works fine 🎉 . Also like how the GUI is positioned now!

@joshuaellis joshuaellis mentioned this pull request Apr 24, 2021
6 tasks
@Gabana
Copy link

Gabana commented Jan 19, 2022

Hey Ricardo, the link to the example doesn´t work. Is it still uploaded? if so, can you please update it? Thanks!

@mrdoob
Copy link
Owner Author

mrdoob commented Jan 19, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants