Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDZExporter: Remove obsolete code in buildVector2Array(). #27264

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 28, 2023

Related issue: -

Description

The PR removes a if clause from buildVector2Array() that is never executed. That happens since #25996 because buildPrimvars() now always calls buildVector2Array() with a defined attribute.

@mrdoob The code that adds default uvs was present since the first commit of the exporter. I'm not sure defining default uvs is required but the respective code has no effect right now.

@mrdoob mrdoob added this to the r159 milestone Nov 28, 2023
@mrdoob mrdoob merged commit 3543d2a into mrdoob:dev Nov 28, 2023
11 checks passed
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants