Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: bump @monogrid/gainmap-js to v3.0.0 in webgl_loader_texture_hdrjpg.html #27277

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

daniele-pelagatti
Copy link
Contributor

Related issue: Issue in gainmap-js repository

Description

This fixes a problem in this specific example (the root cause of the problem in the three.js library remains unknown) where WebGLCubeMap generation using an Equirectangular renderTarget (allowed by #27230) with generateMipmaps = true caused visual artifacts (see below).

Our library now doesn't create renderTargets with generateMipmaps = true by default anymore, this solves this specific problem in this example.

before

before

after

after

The example is now updated and working as intended (plus I added dispose() methods, which free up GPU memory)

…eneration using an equirectangular rendertarget with mipmaps
@Mugen87 Mugen87 added this to the r159 milestone Nov 29, 2023
@Mugen87 Mugen87 merged commit 042c310 into mrdoob:dev Nov 29, 2023
11 checks passed
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
…eneration using an equirectangular rendertarget with mipmaps (mrdoob#27277)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants