Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DracoLoader: Fix not calling onError(). #27306

Merged
merged 4 commits into from
Dec 4, 2023
Merged

DracoLoader: Fix not calling onError(). #27306

merged 4 commits into from
Dec 4, 2023

Conversation

Benjythebee
Copy link
Contributor

@Benjythebee Benjythebee commented Dec 4, 2023

Fixed #20883

Description

I'm aware the dracoLoader might be getting a refactor sometime in the future, however in the meantime, this needed to be addressed;
The problem is that the onError is never called on failed DracoLoader load;

This PR fixes this issue by passing the promise reject to the onError argument

Please feel free to edit this PR if needed.

@Mugen87 Mugen87 added this to the r160 milestone Dec 4, 2023
@Mugen87 Mugen87 changed the title DracoLoader: Fix not calling onError DracoLoader: Fix not calling onError(). Dec 4, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 4, 2023

Let's give this a try!

@Mugen87 Mugen87 merged commit 4a1a1c8 into mrdoob:dev Dec 4, 2023
11 checks passed
@Methuselah96 Methuselah96 mentioned this pull request Dec 5, 2023
13 tasks
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
* fix onError load

* onError

* LinearSRGBColorSpace instead of undefined

* default onError = () => {}; call onError to cleanup code;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draco decoding errors result in uncaught promise rejections.
3 participants