Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerspectiveCamera: getViewBounds(), getViewSize() #27605

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented Jan 21, 2024

Follow-on to #27574.

This PR renames two methods to be consistent with the nomenclature suggested by @gkjohnson.

It also parallels the existing nomenclature: setViewOffset(), clearViewOffset().

getViewBounds() and getViewSize() work correctly when a view offset is specified.

@WestLangley WestLangley added this to the r161 milestone Jan 21, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
673.5 kB (167.2 kB) 673.5 kB (167.2 kB) +3 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
454.2 kB (110.1 kB) 454.2 kB (110.1 kB) +3 B

@Mugen87 Mugen87 merged commit 1c32bbd into mrdoob:dev Jan 22, 2024
12 checks passed
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 22, 2024

/cc @Bug-Reaper

@WestLangley WestLangley deleted the dev-camera_view branch January 22, 2024 15:54
@Bug-Reaper
Copy link
Contributor

Love this 🤌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants