Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DMLoader: Fix typos and reorder imports alphabetically #27631

Merged
merged 2 commits into from
Jan 29, 2024
Merged

3DMLoader: Fix typos and reorder imports alphabetically #27631

merged 2 commits into from
Jan 29, 2024

Conversation

GitHubDragonFly
Copy link
Contributor

@GitHubDragonFly GitHubDragonFly commented Jan 28, 2024

Related issue: None

Description

  • Fix typos and reorder imports alphabetically

- Also modify the default MeshStandardMaterial params:
  - change metalness value from 0.8 to 0.1
  - add roughness value at 0.6
mat.clearCoat = pbr.clearCoat;
mat.clearCoatRoughness = pbr.clearCoatRoughness;
mat.clearcoat = pbr.clearcoat;
mat.clearcoatRoughness = pbr.clearcoatRoughness;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fraguada Can you confirm these changes are correct?

Revert arbitrary changes
@GitHubDragonFly
Copy link
Contributor Author

Just to show what this PR is based on, here is the picture of the Rhino3dm Module as logged in the browser console and showing the property names of the PhysicallyBasedMaterial.

Rhino3dm Module (console output)

@Mugen87 Mugen87 added this to the r161 milestone Jan 29, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 29, 2024

Another reference: https://developer.rhino3d.com/api/rhinocommon/rhino.docobjects.physicallybasedmaterial

I guess it's safe to merge then^^.

@Mugen87 Mugen87 merged commit 6050a4c into mrdoob:dev Jan 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants