Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Support for split assignment #27796

Merged
merged 1 commit into from
Feb 21, 2024
Merged

TSL: Support for split assignment #27796

merged 1 commit into from
Feb 21, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Feb 21, 2024

Related issue: #26982

Description

Adding support for split assignment in TSL, GLSL allows defining multiple components of a vector like v.xy = a.xy while WGSL does not offer this support. The PR adds this compatibility to WGSL by splitting the assign into multiple lines of v.x = a.x; v.y = a.y;. This improves support for codes transpiled from GLSL to TSL.

@sunag sunag added this to the r162 milestone Feb 21, 2024
@sunag sunag marked this pull request as ready for review February 21, 2024 23:16
@sunag sunag merged commit 1b958db into mrdoob:dev Feb 21, 2024
11 checks passed
@sunag sunag deleted the dev-assign branch February 21, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant