Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Update path tracer environment and background selectively #27847

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #27780 (comment)

Description

Prevent the editor from rebuilding the full scene on environment or background change.

@mrdoob mrdoob added this to the r163 milestone Mar 1, 2024
@mrdoob mrdoob merged commit c3fb29d into mrdoob:dev Mar 1, 2024
11 checks passed
@mrdoob
Copy link
Owner

mrdoob commented Mar 1, 2024

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Mar 1, 2024

Background and environment rotation support coming soon? #27847 😇

@gkjohnson gkjohnson deleted the pt-editor-background-update branch March 1, 2024 06:43
@gkjohnson
Copy link
Collaborator Author

gkjohnson commented Mar 1, 2024

Background and environment rotation support coming soon? #27847 😇

Did you mean to link a different issue?

And background / environment rotation is already supported in the path tracer with environmentRotation! We just have to hook it up. Maybe the API should change to match three's now, though.

@mrdoob
Copy link
Owner

mrdoob commented Mar 1, 2024

Did you mean to link a different issue?

I did yeah... Github autocompleted the wrong PR 😒

And background / environment rotation is already supported in the path tracer with environmentRotation!

Oh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants