Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture: Introduce pmremVersion #27963

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Texture: Introduce pmremVersion #27963

merged 1 commit into from
Mar 22, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Mar 21, 2024

Related issue: #XXXX

Description

Following the same logic of needsUpdate, it prevent loss the flag needsPMREMUpdate sharing the same texture with multiples renderers or components.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
670.8 kB (166.3 kB) 670.9 kB (166.3 kB) +119 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
450.8 kB (108.9 kB) 450.9 kB (108.9 kB) +119 B

@sunag sunag marked this pull request as ready for review March 21, 2024 16:54
@sunag sunag requested a review from Mugen87 March 21, 2024 16:54
@Mugen87 Mugen87 added this to the r163 milestone Mar 21, 2024
@sunag sunag merged commit 95eb6f2 into mrdoob:dev Mar 22, 2024
12 checks passed
@sunag sunag deleted the dev-pmremversion branch March 22, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants