Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Apply setupDepth even if fragmentNode isn't null #28043

Merged

Conversation

RenaudRohlinger
Copy link
Collaborator

Description

Building on issue #28042, similar to clippingNode, this pull request ensures that the shared custom depthNode is applied even when the fragmentNode is not null. This adjustment is crucial because setupShadow generates an overrideMaterial that, by default, includes a fragmentNode.

/cc @sunag

This contribution is funded by Utsubo

@RenaudRohlinger RenaudRohlinger added this to the r164 milestone Apr 1, 2024
@sunag sunag merged commit 9b5d697 into mrdoob:dev Apr 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants