Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshGouraudMaterial: Remove unused lightmap_fragment chunk #28056

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

pailhead
Copy link
Contributor

@pailhead pailhead commented Apr 3, 2024

Description

Looking at the shader templates, it seems that the basic material inlines this chunk, and the only other mention of it is within an example material.

  • Remove the unused file.
  • Remove include of chunk in goraud example.
  • Remove import of chunk into chunk lib

@pailhead pailhead force-pushed the dbosnjak/remove-unused-chunk branch from 506c05b to c49b2ae Compare April 3, 2024 08:12
Copy link

github-actions bot commented Apr 3, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
674.4 kB (167.2 kB) 674.4 kB (167.2 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
453.9 kB (109.6 kB) 453.9 kB (109.6 kB) +0 B

@donmccurdy donmccurdy changed the title Remove unused lightmap_fragment chunk MeshGouraudMaterial: Remove unused lightmap_fragment chunk Apr 7, 2024
@Mugen87 Mugen87 added this to the r164 milestone Apr 18, 2024
@Mugen87 Mugen87 merged commit 84b7b88 into mrdoob:dev Apr 18, 2024
10 of 11 checks passed
@pailhead
Copy link
Contributor Author

Thanks! Sorry I got sidetracked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants